docs: add workflow badges to the README #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
reviewed
Nov 16, 2023
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
Hmm, I'm wondering if we really need/want all of these. Maybe just the Charmcraft pack and CI Status ones?
There was a problem hiding this comment.
I don't think they are super useful in the README itself. I'm not sure what the aim is with the releases page. @jnsgruk what workflows would you like to see showing up there?
There was a problem hiding this comment.
I think probably just the ops test workflow and the publish workflow?
There was a problem hiding this comment.
Thanks, changed!
jnsgruk
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add badges for the Github workflows (except publish) to the README.
These will show when viewing the README in a markdown reader that loads external images (e.g. on Github itself) but more importantly also show the CI status on the Juju releases page.